refactor path resolution #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Better path resolution. WASI applications should have no knowledge of the underlying host file system. Prior to this commit, those details were exposed in a few edge cases. - Added support for reading and following symlinks. Prior to this commit, that worked, but the content of the symlinks were based on the host syste, which was wrong. - Writing symlinks works on non-Windows platforms now. - Remove use of strtok().
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 17, 2020
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
Trott
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 17, 2020
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 17, 2020
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 14, 2020
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 17, 2020
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following improvements:
no knowledge of the underlying host file system. Prior
to this commit, those details were exposed in a few
edge cases.
Prior to this commit, that worked, but the content of
the symlinks were based on the host syste, which was
wrong.
The CI seems to be passing. More importantly, I successfully ran these changes through the Node.js CI (https://ci.nodejs.org/job/node-test-commit/34852/).