-
Notifications
You must be signed in to change notification settings - Fork 20
ci: add github-actions ci lint, coverage and nightly #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Do we have any rules or guidelines regarding GitHub actions @nodejs/tsc? |
I think @nodejs/build may be experimenting with them in places? AFAIK, there are no guidelines or rules. This seems OK to me, but perhaps superfluous because you already have Travis? Although maybe it does stuff Travis doesn't. Anyway, I defer to others on this, but I don't have a problem with it. |
My sense is that GitHub Actions is more modern than Travis CI in many ways and more pleasant to work with but it remains in Beta until November so there is still quirkiness. |
no guidelines and not much experimentation (if any?) in the org. I'd encourage experimentation like this because it's bound to become standard over time in the org and the sooner we figure out best practices the better. +1 |
Other Actions experiments: |
Very sorry @cclauss, thanks for the correction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry @panva, I forgot about this. Would you mind updating the minimum Node.js version to match |
@tniessen done, it'll take a merge to master to see the action run tho. |
Adds Github Actions CI with the following jobs
example run