Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

ci: add github-actions ci lint, coverage and nightly #19

Merged
merged 1 commit into from
Jan 12, 2020
Merged

ci: add github-actions ci lint, coverage and nightly #19

merged 1 commit into from
Jan 12, 2020

Conversation

panva
Copy link
Member

@panva panva commented Aug 17, 2019

Adds Github Actions CI with the following jobs

  • lint
  • test matrix on all actions-available platforms + minimal and current node versions
  • test on nightly

example run

Copy link

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tniessen
Copy link
Member

tniessen commented Sep 5, 2019

Do we have any rules or guidelines regarding GitHub actions @nodejs/tsc?

@Trott
Copy link
Member

Trott commented Sep 5, 2019

Do we have any rules or guidelines regarding GitHub actions @nodejs/tsc?

I think @nodejs/build may be experimenting with them in places? AFAIK, there are no guidelines or rules. This seems OK to me, but perhaps superfluous because you already have Travis? Although maybe it does stuff Travis doesn't.

Anyway, I defer to others on this, but I don't have a problem with it.

@cclauss
Copy link

cclauss commented Sep 6, 2019

My sense is that GitHub Actions is more modern than Travis CI in many ways and more pleasant to work with but it remains in Beta until November so there is still quirkiness.

@rvagg
Copy link
Member

rvagg commented Sep 9, 2019

no guidelines and not much experimentation (if any?) in the org. I'd encourage experimentation like this because it's bound to become standard over time in the org and the sooner we figure out best practices the better. +1

@rvagg
Copy link
Member

rvagg commented Sep 9, 2019

Very sorry @cclauss, thanks for the correction

Copy link

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tniessen
Copy link
Member

Sorry @panva, I forgot about this. Would you mind updating the minimum Node.js version to match package.json so I can land this?

@panva
Copy link
Member Author

panva commented Jan 12, 2020

@tniessen done, it'll take a merge to master to see the action run tho.

@tniessen tniessen merged commit e84296c into nodejs:master Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants