-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIFFS issues with 1.5.4 branch? #1997
Comments
How much space is left for the filesystem? What does |
Spot on, thanks! It never occurred to me that lack of space could be the reason. I would have expected other types of failures in such cases. I stripped the firmware of a few modules and now life is good (apart from the missing modules 🙁 ). Results for:
Couldn't/shouldn't the firmware check for min size at https://github.com/nodemcu/nodemcu-firmware/blob/1.5.4.1-final/app/modules/file.c#L146 or before |
I've been looking at the code, and (of course) it isn't that simple. My feeling is that fixing the message would help, and adding some output that reported exactly what was going on would be helpful. I'm thinking that just adding a print in the innards of the format code to say that there is insufficient space -- that this will be enough. |
I agree and I'd appreciate a fix for this. So, you'd add to |
Philip, since the 1.5.4 branch is labeled frozen do you think this should be fixed at all? |
No -- this is a curious error case. There are other fixes in the core spiffs codebase that we ought to pick up..... |
I propose that we fix this when we merge in the new version of spiffs..... |
How? Do you plan to back-port #2172 to the frozen 1.5.4 branch? |
I would only fix for the 2.1.0 branch going forwards..... |
I'm trying to finally put some old 512KB modules to use. I flashed them with a binary from the frozen 1.5.4 branch. Upon start the firmware fails to format the file system.
Output from esptool.py
Output from NodeMCU start
Note: debug is enabled as you'll see
I tried this with two ESP-01 and a ESP-201, the behavior is the same for all. I also tried with esptool.py 1.3 (instead of 2.0 beta). It doesn't make any difference whether the flash mode is QIO or DIO. And I did try re-flashing and
esptool.py erase_flash
before flashing.Apart from the SPIFFS issue the firmware seems to run fine (tried WiFi and I2C with BME280).
@pjsg any ideas? Since a significant number of people use binaries from the 1.5.4 branch I somehow doubt this is a firmware issue - we would have learned about it long ago. Yet, it irritates me that I'm seeing this behavior on three different devices.
The text was updated successfully, but these errors were encountered: