Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for README.md #2418

Closed
TerryE opened this issue Jul 2, 2018 · 8 comments
Closed

Wording for README.md #2418

TerryE opened this issue Jul 2, 2018 · 8 comments

Comments

@TerryE
Copy link
Collaborator

TerryE commented Jul 2, 2018

Another issue that doesn't fit the templates. This is a trivial one but worth discussing and reaching consensus before raising the PR. There are a could of issues with the project README that deserve fixing. (Many thanks to @nailujx86 for raising this).

  • The lede is just misleading and needs replacing. For example: it majors on eLua, whilst in reality perhaps 85% of the Lua hierarchy is standard Lua. Of the remaining mods and new code, my and zeroday's mods / enhancements are a far larger portion than the eLua components (mainly ROTable handling). To all intents the code is 100% c. Also whilst the project started out a companion to the NodeMCU boards, it can be run on any ESP module. So how about:

NodeMCU is an open source Lua based firmware for the ESP8266 WiFi SOC from Espressif and uses an on-module flash-based SPIFFS file system. NodeMCU is implemented in C and is layered on the Espressif NON-OS SDK 2.2.0.

  • We should also underline that the project is now run by community members and is vendor-neutral in terms of hardware:

The firmware was initially developed as is a companion project to the popular ESP8266-based NodeMCU development modules, but the project is now community-supported, and the firmware can now be run on any ESP module.

@marcelstoer
Copy link
Member

Fine for me, I like. Two issues:

  • Don't mention the exact NON-OS SDK version. Would be one less place to edit with every SDK upgrade.
  • "can now be run on any ESP module." - I don't think the term "ESP module" has any official meaning.

How about

...nity-supported. The firmware can now be run on any ESP8266, ESP8285 and ESP32.

-> maybe mention something about the respective NodeMCU branches?

@TerryE
Copy link
Collaborator Author

TerryE commented Jul 2, 2018

Good points which is why I felt that issue would be more appropriate now.

I must admit that I tend to use ESP module as a short hand. Your list is specific: maybe we should just use it to introduce the defined term (ESP Module).

I agree that we should discuss the branches, at least master, dev and dev-esp32, but I feel this fits in better slightly further down the readme.

@cwrseck
Copy link

cwrseck commented Jul 3, 2018

It would be helpful to add the release version (eg. 2,2,0-master_20180608) to the title of the README title. I have several versions of NodeMCU, and it's tedious to have to check the source directory to find out which version's documentation I've found.

Will

@TerryE
Copy link
Collaborator Author

TerryE commented Jul 3, 2018

@cwrseck. I can't follow your logic here. The README is in the source directory. How do you do your build? Via cloud builder or what? From our PoV, having the version in the README is a PITA as you now have to update this file every release.

@cwrseck
Copy link

cwrseck commented Jul 4, 2018

I have a docs link on the desktop, effectively (I'm building NodeMCU from a local directory). With various versions in play, it's handy to know which version of the docs goes with which without scuffling through the file system. In general I'd expect the version number to be updated automatically when each new release is built, but there may well be difficulties I'm not aware of.

Will

@TerryE
Copy link
Collaborator Author

TerryE commented Jul 4, 2018

Surely, if you are building NodeMCU locally then you are surely running a Linux dev system, in which case it's only going to be a few line script in an alias or ~/bin to do whatever you want?

@TerryE TerryE mentioned this issue Jul 4, 2018
4 tasks
@marcelstoer
Copy link
Member

worth discussing and reaching consensus before raising the PR

Ready for PR IMHO.

marcelstoer added a commit that referenced this issue Jul 24, 2018
@marcelstoer
Copy link
Member

Fixed in 8505362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants