Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U8g2: display drivers are not compiled #2806

Closed
shimosaurus opened this issue Jun 21, 2019 · 2 comments
Closed

U8g2: display drivers are not compiled #2806

shimosaurus opened this issue Jun 21, 2019 · 2 comments
Assignees

Comments

@shimosaurus
Copy link

Expected behavior

> print(u8g2.ssd1306_i2c_128x64_noname)
lightfunction: 0x402630d0

Actual behavior

> print(u8g2.ssd1306_i2c_128x64_noname)
nil

NodeMCU version

Actual dev branch.
Broken in PR: Updated ROTables 1st tranch #2742

Solution

Remove "#" from "#binding" in /app/modules/u8g2.c

patch:

@@ -807,7 +807,7 @@
 
 #undef U8G2_FONT_TABLE_ENTRY
 #undef U8G2_DISPLAY_TABLE_ENTRY
-#define U8G2_DISPLAY_TABLE_ENTRY(function, binding) LROT_FUNCENTRY(#binding,l ## binding)
+#define U8G2_DISPLAY_TABLE_ENTRY(function, binding) LROT_FUNCENTRY(binding,l ## binding)
 LROT_BEGIN(lu8g2)
   U8G2_DISPLAY_TABLE_I2C
   U8G2_DISPLAY_TABLE_SPI
@TerryE TerryE self-assigned this Jun 22, 2019
@TerryE
Copy link
Collaborator

TerryE commented Jun 22, 2019

Thanks @shimosaurus, I will sneak this into my next PR. Sorry about this, and the fix is much appreciated. 😊

marcelstoer added a commit that referenced this issue Jun 22, 2019
@marcelstoer
Copy link
Member

I will sneak this into my next PR

No need, I just fixed this on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants