-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua_examples/luaOTA crashes when entering _init.lua #2954
Comments
Thanks @sognetic. I'll take a look in the next day or so. |
I'm seeing same issue with:
|
luaOTA seems behind the current version of the firmwork. |
@adeltc Please go ahead making a push request. |
ok the pull request is done : https://github.com/adeltc/nodemcu-firmware/pull/1 |
@adeltc thanks for the findings and for creating a pull request. There are some things which went the wrong way though. When updating a branch with the newest commits from the dev branch use rebase instead of merge. If you use merge all the commits from other contributors will show up and it will be difficult to see your changes. I just saw that your repo does not seem to be a fork of nodemcu/nodemcu-firmware, so you would have to fork nodemcu/nodemcu-firmware first and then create a branch off of dev, push your changes and create the PR. When creating the PR online you can also see the changes it contains. If there is anything but yours, something is wrong. |
Really sorry about this mistake. I'm currently fixing it. |
Hopefully this one would be the right one : #3015 |
Even that I based my new branch on dev branch, the pull request has another based branch configuration that I didn't see. I realised it was based on master. I just made antoher pull request with dev as base branch : #3016 |
Expected behavior
I've been trying to use the luaOTA example from lua_examples to do deployment.
Expected behaviour is thus: Not crashing.
.
Actual behavior
Code immediately panics when entering _init.lua with
Test code
MCVE is simply uploading the code in luaOTA (minus the server component) to the ESP
NodeMCU version
master
commit: 310faf7
Hardware
NodeMCU board Ver. 0.1 (?)
The text was updated successfully, but these errors were encountered: