Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time frame for removal of deprecated tmr functions #1533

Closed
wants to merge 1 commit into from

Conversation

marcelstoer
Copy link
Member

This came up while reviewing #1532.

@marcelstoer marcelstoer added this to the Post-1.5.4.1-II milestone Oct 9, 2016
@pjsg
Copy link
Member

pjsg commented Oct 9, 2016

I hadn't realized that we had dynamic timers.... I must have lifted some sample code when I wrote my first app, and that used static timers.

@devsaurus
Copy link
Member

A deadline is good for me, but it might be missed by users.

How about a notification message when static timers are being used, to warn users upfront? Like a deprecation "roadmap":
Next master drop E/November: message about upcoming removal (maybe 10 times after reset)
Drop E/January: static timer support finally removed

@marcelstoer
Copy link
Member Author

marcelstoer commented Oct 10, 2016

I hadn't realized that we had dynamic timers

It was only added two months ago with #1424.

How about a notification message when static timers are being used, to warn users upfront?

Good idea. I obviously wouldn't know right now how to implement that but I'm convinced I'll figure it out.
I'll create a PR when I'm done. So, that shouldn't hold this one up.

Like a deprecation "roadmap".

Great! In the future we should add that to the release notes - which requires we establish one when a PR with API-replacements is merged. As long as we stick to our 2-months rhythm a 6-months deprecation time frame would IMO be fine.

@marcelstoer
Copy link
Member Author

marcelstoer commented Nov 12, 2016

The thing with the notification message is being discussed in #1538.

But how are we going to proceed here? If there's a clearly defined time frame in the docs we must have someone willing to actually remove the deprecated stuff by that time. This being all voluntary we probably won't ever have that sort of commitment from anyone.

Therefore, I'm inclined to close this because it sets unrealistic expectations.

@marcelstoer marcelstoer removed this from the Post-1.5.4.1-II milestone Nov 15, 2016
@marcelstoer marcelstoer deleted the dev-tmr-docs branch November 15, 2016 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants