Add file.stat() to query file/directory attributes. #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jmattsson
reviewed
Jan 17, 2017
| @@ -13,6 +13,14 @@ | |||
|
|
|||
| #define FILE_READ_CHUNK 1024 | |||
|
|
|||
| // use this time/date in absence of a timestamp | |||
| #define FILE_TIMEDEF_YEAR 2016 | |||
There was a problem hiding this comment.
Can I recommend using a more common value for the epoch? E.g. the Unix epoch (Jan 1, 1970) or ZigBee (Jan 1, 2000).
There was a problem hiding this comment.
Ok, the Unix epoch is used now as default.
| lua_pushstring( L, key ); | ||
| lua_pushboolean( L, b ); | ||
| lua_rawset( L, -3 ); | ||
| } |
There was a problem hiding this comment.
Instead/for all of the above helpers, why not use lua_setfield()?
There was a problem hiding this comment.
I wasn't aware of this function, changed.
|
|
||
| - `size` file size in bytes | ||
| - `name` file name | ||
| - `time` table with time stamp information. Default is 2016-06-21 00:00:00 in case time stamps are not supported (on SPIFFS). |
There was a problem hiding this comment.
Don't forget this if changing the epoch...
|
Wouldn't that make sense for the OO API as well: |
use lua_setfield
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augments to #1321.
devbranch rather than formaster.docs/en/*.New function
file.stat()retrieves file/directory attributes in a table:Works on both SPIFFS and FatFs, with SPIFFS providing meaningful information only for name and size (other items are present but default).