Use flash size byte to determine the location of the init data for byte 107. #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the bug is back in master. |
|
Yes it is. See #2925 |
|
@vladzaets, please use the open #2925 for any further comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1826.
devbranch rather than formaster.The current method to determine the location of the init data sector for byte 107 assumes that it's at offset -4 from the end of the flash. This logic breaks in case the current workaround for >4MB modules is present where init data is not located at the end of flash.
Fix is to determine init data location with
flash_rom_get_sec_num()which relies on the size header byte. Size byte is the single source pointing to the init data location in all cases since the SDK also uses this information to locate init data.This method is expected to remain valid also for the upcoming support of >4MB flash by the SDK (tagging #1810 for regression testing).
Tested on a 16MB Mini Pro and a stock 4MB NodeMCU devkit.