Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and example for wps.start() #1933

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

dnc40085
Copy link
Contributor

@dnc40085 dnc40085 commented Apr 23, 2017

Addresses issue #1930.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.

The documentation for wps.start() didn't provide enough information on how to successfully connect the station to an access point via wps, so I added more detail to the description and added an additional example.

@dnc40085 dnc40085 force-pushed the dev_WPS_documentation_update branch from f9aee00 to c6bf473 Compare April 23, 2017 23:46
@dnc40085 dnc40085 force-pushed the dev_WPS_documentation_update branch from c6bf473 to 5d3e8b6 Compare April 24, 2017 00:06
@FrankX0
Copy link
Contributor

FrankX0 commented Apr 24, 2017

Thanks @dnc40085!

@marcelstoer marcelstoer added this to the 2.0.0-follow-up milestone Apr 24, 2017
@marcelstoer marcelstoer merged commit f5fac7a into nodemcu:dev Apr 24, 2017
@dnc40085 dnc40085 deleted the dev_WPS_documentation_update branch April 24, 2017 08:36
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants