Update init.lua example to use new wifi.sta.config() implementation #1953
Conversation
docs/en/upload.md
Outdated
| -- Define WiFi station event callbacks | ||
| wifi_connect_event = function(T) | ||
| print("Connection to AP("..T.SSID..") established!") | ||
| print("Wating for ip...") |
|
👍 in general |
dnc40085
force-pushed
the
dev_update_init.lua_example
branch
from
1cb7551
to
1d80d02
Compare
|
Woah, a really elaborate template, thanks. Did you consider to drop the "Inspired by " note at the end (it has deviated quite a bit)? I'll add some notes/questions inline. @jmattsson what does your cautious "in general" mean? I interpret this as if you were not fully satisfied with the proposal? |
docs/en/upload.md
Outdated
| -- Define WiFi station event callbacks | ||
| wifi_connect_event = function(T) | ||
| print("Connection to AP("..T.SSID..") established!") | ||
| print("Waiting for ip...") |
There was a problem hiding this comment.
How about "Waiting for IP address..."?
docs/en/upload.md
Outdated
| for key,val in pairs(wifi.eventmon.reason) do | ||
| if val == T.reason then | ||
| print("Disconnect reason:"..T.reason.."("..key..")") | ||
| reason_string=key |
There was a problem hiding this comment.
Why do you keep reason_string? I don't see it being used anywhere...
There was a problem hiding this comment.
I was going to add the disconnect reason to the final abort message, but I decided not to and I forgot to remove this variable.
docs/en/upload.md
Outdated
| --the list and returns the string corresponding to the disconnect reason. | ||
| for key,val in pairs(wifi.eventmon.reason) do | ||
| if val == T.reason then | ||
| print("Disconnect reason:"..T.reason.."("..key..")") |
There was a problem hiding this comment.
How about "Disconnect reason: "..val.." ("..key..")"?
docs/en/upload.md
Outdated
| return | ||
| end | ||
| -- total_tries: how many times the station will attempt to connect to the AP. | ||
| local total_tries = 3 |
There was a problem hiding this comment.
As a default value I would increase this significantly (or drop it altogether) to accommodate for intermittent AP reboots.
There was a problem hiding this comment.
does 30 sound good?
There was a problem hiding this comment.
It does but I haven't tested how this translates to time. Would it be safe to assume that APs take anywhere between 30s and 60s to boot?
There was a problem hiding this comment.
My Comcast Xfinity gateway(Arris technicolor tc8305c) takes about 2.5 min to reboot and the interval between NO_AP_FOUND disconnect events is about 2.25 seconds, so I think a value of 75 should cover most cases.
|
Oh, just the typo at the time :) |
dnc40085
force-pushed
the
dev_update_init.lua_example
branch
from
c5d9ae9
to
d77ba57
Compare
…odemcu#1953) * Update init.lua example in upload.md with new station config format * Fixed typo in description of wifi.eventmon.register() * Fixed typo and improved example init.lua in docs/en/upload.md
Fixes #1951 .
devbranch rather than formaster.docs/en/*.When I updated the function
wifi.sta.config()to accept a table for station configuration, I forgot to update theinit.luaexample indocs/en/upload.mdaccordingly.The new version of the example also makes use of the event monitor rather than a timer to catch station events.