Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of the Lua DS18B20 module #1996

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Rewrite of the Lua DS18B20 module #1996

merged 1 commit into from
Aug 16, 2017

Conversation

vsky279
Copy link
Contributor

@vsky279 vsky279 commented Jun 2, 2017

Implements suggestions discussed in #1883 and flaws pointed out in #1820 with @TerryE.

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at README.md.

Features:

  • the module is fully asynchronous (no use of tmr.delay)
  • supports powered and parasitic-powered devices and its combinations on the same bus
  • both float and integer versions of Lua are supported
  • optional storing and retrieval of address to flash

Feel free to comment and suggest further improvements.

@marcelstoer marcelstoer added this to the 2.1 follow-up milestone Jun 4, 2017
@fetchbot fetchbot mentioned this pull request Jun 11, 2017
4 tasks
@marcelstoer marcelstoer requested a review from TerryE July 8, 2017 20:52
@marcelstoer marcelstoer removed this from the 2.1 follow-up milestone Jul 18, 2017
@marcelstoer marcelstoer added this to the 2.1 follow-up II milestone Aug 16, 2017
@marcelstoer marcelstoer merged commit 55c368a into nodemcu:dev Aug 16, 2017
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants