Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wifi.sta.config to save configuration to flash by default #1998

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

dnc40085
Copy link
Contributor

@dnc40085 dnc40085 commented Jun 5, 2017

Fixes #1940.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

This PR updates wifi.sta.config() to save configuration by default.

@dnc40085 dnc40085 force-pushed the dev_fix_wifi_sta_cfg_update branch from 8e20007 to 5ada91b Compare June 5, 2017 21:42
@dnc40085 dnc40085 force-pushed the dev_fix_wifi_sta_cfg_update branch from 5ada91b to c99456b Compare June 28, 2017 23:42
@dnc40085 dnc40085 force-pushed the dev_fix_wifi_sta_cfg_update branch from c99456b to 4159d17 Compare June 28, 2017 23:47
@marcelstoer marcelstoer added this to the 2.1 follow-up milestone Jul 8, 2017
@marcelstoer marcelstoer merged commit 9edcce5 into nodemcu:dev Jul 8, 2017
@rupeshsalgaonkar
Copy link

I am getting following error what can be wrong
bad argument #1 to 'config' (config table not found!)

@marcelstoer
Copy link
Member

eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
@dnc40085 dnc40085 deleted the dev_fix_wifi_sta_cfg_update branch March 6, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants