default flash mode to dio in fw image header #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a bit unfortunate we have to make this change but the esptool.py upgrade makes this a logical consequence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2009.
devbranch rather than formaster.docs/en/*.#2009 revealed that esptool.py changed defaults for flash mode and flash frequency to
keepduringwrite_flash, exposing the related content in the firmware image files we produce during build.To ensure a safe default configuration (mainly for flash mode) which is expected to work for any board, this PR forces flash mode to
dioand flash frequency to40minside the image.