Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the wifi monitor mode in the SDK #2204

Merged
merged 27 commits into from
Jan 10, 2018
Merged

Conversation

pjsg
Copy link
Member

@pjsg pjsg commented Dec 20, 2017

Fixes #2203

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

This is the addition of a new module to get access to (initially) the management frames that are being broadcast by APs. It look longer than I expected due to some undocumented subtleties in the SDK. This was finally clarified in espressif/ESP8266_NONOS_SDK#72 as to what I was doing wrong (though I don't think that a null pointer exception is a very friendly way of signalling a problem!)

This works remarkably well on boards like the Wemos D1 Mini Pro which has an external antenna (but you do need to resolder a jumper to make the external antenna work).

@marcelstoer
Copy link
Member

I haven't tested but this looks really helpful. I would prefer having the documentation into its own file (rather than appending to WiFi). One file per module you configure in user_modules.h or so.

@pjsg
Copy link
Member Author

pjsg commented Dec 21, 2017

OK -- I wondered about that. The wifi.eventmon stuff is in the same file, but it is enabled somewhat differently. The wifi.md file is already pretty large. I'll refactor the docs.

@pjsg
Copy link
Member Author

pjsg commented Dec 22, 2017

Updates complete. Also improved docs a bit. I suspect that there are other use cases for this monitor mode that could be supported in the future.

@marcelstoer marcelstoer added this to the 2.2 milestone Jan 10, 2018
@marcelstoer marcelstoer merged commit ceadd30 into nodemcu:dev Jan 10, 2018
dnc40085 pushed a commit to dnc40085/nodemcu-firmware that referenced this pull request Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants