-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTU21D/SHT21 temperature and humidity sensors #2249
Conversation
app/modules/htu21.c
Outdated
return (uint8_t) remainder; | ||
} | ||
|
||
static uint16_t ICACHE_FLASH_ATTR read_with_crc_check(lua_State *L, uint8_t reg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don;t need the ICACHE_FLASH_ATTR as all nodemcu functions default to flash unless otherwise specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, I've removed the ICACHE_FLASH_ATTR
Please add I2C id as parameter to |
Hmm, this PR unfortunately is so old that it does not contain several changes we did. Pity that it wasn't picked up earlier. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
dev
branch rather than formaster
.docs/en/*
.HTU21D is cheap digital temperature and humidity sensor.