Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ar from esp toolchain instead of host #2446

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

devsaurus
Copy link
Member

Fixes #2444.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.

The steps for preparing the binary libraries use ar from the host's toolchain. This appears to fail sometimes as reported in the related issue.
Since we're operating on archives for the target esp system, I'd say it's safer to use ar from the target xtensa toochain.

@TerryE TerryE merged commit c75be87 into nodemcu:dev Aug 1, 2018
@TerryE
Copy link
Collaborator

TerryE commented Aug 1, 2018

Thanks, Arnim 😃

@marcelstoer marcelstoer added this to the next-release milestone Aug 2, 2018
@devsaurus devsaurus deleted the use_target_toolchain branch August 2, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants