Fix issue with ADS1115 module #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galjonsfigur
force-pushed
the
dev-ads1115-fix
branch
from
b56ac46
to
a8b43ee
Compare
Me neither but the fix looks sane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2753
devbranch rather than formaster.I was searching for similar bug in other modules but didn't find any and I don't really know why only in this module only
__indexvalue was converted incorrectly. I don't have an ADS1115 chip, so any tests would be appreciated.EDIT:
Also added a fix in documentation mentioned in #2753 - it's small enough to go to this PR.