Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New net.if.info call to show LwIP information #2862

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

nwf
Copy link
Member

@nwf nwf commented Jul 27, 2019

This is a generalization of wifi.sta's and wifi.ap's getip and getmac calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where #2819 has landed, now that #2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

@nwf nwf requested a review from TerryE July 27, 2019 19:19
nwf added 2 commits July 27, 2019 22:42
This file appears to be unused in our tree.
This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
@marcelstoer marcelstoer added this to the Next release milestone Sep 10, 2019
@marcelstoer marcelstoer merged commit f85c278 into nodemcu:dev Dec 9, 2019
vsky279 pushed a commit to vsky279/nodemcu-firmware that referenced this pull request Dec 27, 2019
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
@nwf nwf deleted the net-if-info branch February 2, 2020 15:07
@nwf nwf mentioned this pull request Feb 3, 2020
4 tasks
marcelstoer pushed a commit that referenced this pull request Jun 9, 2020
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
#2819 has landed, now
that #2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants