-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bme280 driver in Lua+C #3132
bme280 driver in Lua+C #3132
Conversation
425ad2e
to
1ccdb8f
Compare
I don't know how to make Travis CI happy when it complains that |
@vsky279 You have to add entities in I thought that I've written documentation on how to add new entities in luacheck config when adding new C module but turns out I was wrong - I could add this in documentation or in project wiki. |
@galjonsfigur Thanks. I did manual update and now it's green. |
2636dba
to
4baaaf6
Compare
Lua 5.3 compatibility issue -
|
luaO_pushfstring(L, "<\\%d>", cast_uchar(buff)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Yes, sorry to have forgotten about this one. I think it's worth landing and beginning to point people at it even if we don't yet quite have the one-shot "here's your firmware with both C and Lua modules in LFS baked in" story worked out in detail. (That depends on #3272 and probably #3138, and so probably won't be ready by next release, just given everyone's schedules, which is a little sad, but so it goes.)
Some minor changes requested.
63d7c18
to
dfc4b62
Compare
Fixes #3126, #3124, #2241,
dev
branch rather than formaster
.docs/*
.Rewritten BME280 driver based on the discussion in #3126.
I intend to add also SPI support (#2527) which should be also relatively small modification of the Lua driver.
There is a conflict when original BME280 module is included in the build.
require('bme280')
references to the original C module and not to the new Lua driver. This can be a bit confusing. The natural solution would be to that this driver replaces the original C driver.I assume this should be probably merged only when #3128 is implemented.
Please review the proposed commit.