Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes lfs/_init.lua compatible with Lua 5.3 #3168
Makes lfs/_init.lua compatible with Lua 5.3 #3168
Changes from all commits
46974a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a question for this PR, but since you're in the neighborhood: should we suggest to advanced developers how to add entries here? People using their own LFS might want their code to still be
luacheck
-clean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nwf I think it would be a good idea to make some kind of documentation on how to use
luacheck
on NodeMCU code. I've writtenluacheck_config_helper.lua
script when I was addingluacheck
support but I haven't documented it anywhere besides some comments in the script itself. Should this be added to GitHub Wiki, Extension Developer FAQ or somewhere else?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am more of the view: what's wrong with RTFM? If anyone wants to read up on how to use luacehck then it comes with a lot of good documentation. May a reference to it in our FAQs.