Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes net.ifinfo failure #3267

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fixes net.ifinfo failure #3267

merged 1 commit into from
Sep 4, 2020

Conversation

vsky279
Copy link
Contributor

@vsky279 vsky279 commented Sep 1, 2020

Fixes #3249.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

This seems to be an easy catch. Only 0 or 1 are eligible parameters to eagle_lwip_getif and dhcp table can be added to the resulting table only when dhcp table is created.

app/modules/net.c Outdated Show resolved Hide resolved
@nwf
Copy link
Member

nwf commented Sep 3, 2020

Looks right to me. @vsky279 Can I get you to squash the two commits together yourself so we can do the "rebase and merge" rather than "squash and merge" that will, I think, leave my name on it rather than yours and @marcelstoer's?

@marcelstoer
Copy link
Member

that will, I think, leave my name on it

Hhmm, what makes you think so? Git(Hub) just records the committer separately from the author if you "squash and merge": https://github.com/nodemcu/nodemcu-firmware/commits/dev. Looks all dandy to me.

@vsky279
Copy link
Contributor Author

vsky279 commented Sep 3, 2020

It's squashed now :-)

@marcelstoer marcelstoer merged commit e28cf8d into nodemcu:dev Sep 4, 2020
@marcelstoer
Copy link
Member

All my tests passed.

@vsky279 vsky279 deleted the c_ifinfo branch September 6, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net.ifinfo fails with "Lua error: attempt to index a number value" or MCU reboot
3 participants