Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the node version to the logger output #193

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

lholmquist
Copy link
Member

This adds a node_version parameter to the logger output, which would make the log look like this:

{"level":30,"time":1678805584609,"pid":14210,"hostname":"lholmqui-mac","node_version":"v18.13.0","reqId":"req-1","res":{"statusCode":204},"responseTime":0.304443359375,"msg":"request completed"}

I thought it might be nice to have this to easily identify the node version someone is using, if they have errors

@lholmquist lholmquist requested review from lance and a team March 14, 2023 15:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (3a689af) 92.36% compared to head (739da7b) 92.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   92.36%   92.39%   +0.02%     
==========================================
  Files           9        9              
  Lines         262      263       +1     
==========================================
+ Hits          242      243       +1     
  Misses         20       20              
Impacted Files Coverage Δ
index.js 87.71% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lholmquist
Copy link
Member Author

Not really sure why the code cov task fails on Node 18 on windows

@lance
Copy link
Member

lance commented Mar 14, 2023

Not really sure why the code cov task fails on Node 18 on windows

I've seen this happen before. Something flakey in the task it seems. Re-running the job (sometimes more than once) helps.

There is also this that we should be addressing... but that's another matter.
image

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance lance added the enhancement New feature or request label Mar 14, 2023
@lance lance merged commit 8cdb40e into nodeshift:main Mar 14, 2023
@lholmquist lholmquist deleted the add_node_version_to_log_output branch March 14, 2023 17:33
lance added a commit to lance/faas-js-runtime that referenced this pull request Mar 16, 2023
The current actions in use (v2 and v1 respectively) use Node.js 12 and
are now deprecated. See: nodeshift#193 (comment)

Signed-off-by: Lance Ball <lball@redhat.com>
lholmquist pushed a commit that referenced this pull request Mar 17, 2023
The current actions in use (v2 and v1 respectively) use Node.js 12 and
are now deprecated. See: #193 (comment)

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants