-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add the node version to the logger output #193
chore: add the node version to the logger output #193
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 92.36% 92.39% +0.02%
==========================================
Files 9 9
Lines 262 263 +1
==========================================
+ Hits 242 243 +1
Misses 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Not really sure why the code cov task fails on Node 18 on windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The current actions in use (v2 and v1 respectively) use Node.js 12 and are now deprecated. See: nodeshift#193 (comment) Signed-off-by: Lance Ball <lball@redhat.com>
The current actions in use (v2 and v1 respectively) use Node.js 12 and are now deprecated. See: #193 (comment) Signed-off-by: Lance Ball <lball@redhat.com>
This adds a
node_version
parameter to the logger output, which would make the log look like this:I thought it might be nice to have this to easily identify the node version someone is using, if they have errors