Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up event unmarshalling, remove async API calls #38

Merged
merged 1 commit into from
May 7, 2020
Merged

chore: clean up event unmarshalling, remove async API calls #38

merged 1 commit into from
May 7, 2020

Commits on May 5, 2020

  1. chore: clean up event unmarshalling, remove async API calls 

    The cloudevents sdk has some inconsistencies with how it exposed the
unmarshalling. Version 0.3 and earlier had an async API, while 1.0
(smartly) changed that. As a result, the impl in this file was pretty
ugly. By using the receivers directly, we can avoid that and clean up
this code.

These changes are based on: cloudevents/sdk-javascript#120

Once those changes land in a released version of the cloudevents sdk
this file can be even simpler as the sdk will handle most of this work.

As an aside - dropped support for 0.2. Normally I wouldn't be so casual about
dropping support, but upstream sdk has no 0.2 support in the next release
and cloud events spec says only the two most recent versions are required
to be supported.
    @lance
    lance committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0b5e881 View commit details
    Browse the repository at this point in the history