Support configurable log levels #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
approved these changes
Apr 10, 2021
Member
lance
left a comment
lance
left a comment
There was a problem hiding this comment.
Thanks @evanshortiss! This is a nice improvement. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configurable log levels.
It's neat that pino is used as the logger, but currently it can only be toggled on/off. This PR will support passing a
logLevelin the options passed to the runtime.This PR defaults the log level to
infowhich provides the same behaviour as the previoustruevalue, so it shouldn't affect people who are OK with the existing defaults when they update.