Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original function parameters to the failure and timeout events #326

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

lholmquist
Copy link
Member

This adds the original functions parameters to the timeout and failure events as the third argument.

The third argument will be an array of values

fixes #324

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit.

test/test.js Outdated Show resolved Hide resolved
@lance lance merged commit f8918c4 into nodeshift:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing function parameters to events
3 participants