feature: Coalesce reset options, reset coalesce based on result. (error, success, timeout) #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 6, 2024 13:55
* main: chore(main): release 8.3.1 (nodeshift#907) fix: Incorrect default value of maxEntries for MemoryCache nodeshift#904 (nodeshift#906) # Conflicts: # lib/cache.js
Merge branch 'main' into coalesce-reset-options * main: chore(main): release 8.3.1 (nodeshift#907) fix: Incorrect default value of maxEntries for MemoryCache nodeshift#904 (nodeshift#906) # Conflicts: # lib/cache.js
Pull Request Test Coverage Report for Build 11931665972Details
💛 - Coveralls |
|
could you also update the readme with this new functionally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing coalescing in our software, we noticed it would be handy to better finetune coalescion behavior.
So added the option to reset coalescion cache at different stages: error, success, timeout. This can be used as sometimes you'd like to retry after an error/timeout, or would like to limit cache TTL without limiting coalescion TTL (e.g. a slow action to fetch data you do want to execute as often as possible but never twice at the same time).