Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update nodejs versions in travis #169

Merged
merged 1 commit into from
Jul 4, 2019
Merged

ci: update nodejs versions in travis #169

merged 1 commit into from
Jul 4, 2019

Conversation

Fishrock123
Copy link
Contributor

12 has been stable a couple months, 13 is master.

@Fishrock123 Fishrock123 requested a review from Raynos July 4, 2019 15:25
@Fishrock123
Copy link
Contributor Author

Fwiw, Node 13 fails (but is ignored):

> npm run -s test-only
/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:1
TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
    at /home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:47:23
    at Object.<anonymous> (/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:181:3)
/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:1
TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
    at /home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:47:23
    at Object.<anonymous> (/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:181:3)
test/details.js ....................................... 0/1
  not ok test/details.js

This is currently a known issue, filed to nodejs/node#28294, originating from standard-things/esm#821.

@Fishrock123
ci: update nodejs versions in travis
32ba612 
12 has been stable a couple months, 13 is master.

PR-URL: #169
@Fishrock123 Fishrock123 merged commit 32ba612 into master Jul 4, 2019
@Fishrock123 Fishrock123 deleted the fishrock/update-ci-nodejs branch July 4, 2019 19:51
@Jazneil Jazneil added this to the Sprint 16 (7/2 - 7/19) milestone Jul 17, 2019
Gioyik pushed a commit that referenced this pull request Apr 22, 2020
@Fishrock123 @Gioyik
ci: update nodejs versions in travis
73c207c 
12 has been stable a couple months, 13 is master.

PR-URL: #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raynos Raynos Raynos approved these changes

@juliangruber juliangruber juliangruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 16 (7/2 - 7/19)
Development

Successfully merging this pull request may close these issues.
4 participants
@Fishrock123 @juliangruber @Raynos @Jazneil