Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 298 fonts location #299

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Issue 298 fonts location #299

merged 2 commits into from
Jun 14, 2024

Conversation

stefanodavid
Copy link
Collaborator

No description provided.

@stefanodavid
Copy link
Collaborator Author

closes #298

@stefanodavid
Copy link
Collaborator Author

@mrabans @sseppi can you please merge this PR?

@mrabans
Copy link
Collaborator

mrabans commented Oct 27, 2023

@stefanodavid please no code reviews from the changes you did. If they do not work, don't commit them. Since you are the maintainer of the read-the-docs documentation, just merge the thing.

@stefanodavid
Copy link
Collaborator Author

@mrabans I am sorry, I didn't want to bother, but apparently I need one approval from a reviewer, otherwise I can not merge. I have no idea why now it is like this, perhaps some repo settings was changed?

@mrabans
Copy link
Collaborator

mrabans commented Oct 27, 2023

@sseppi can you please verify if the repo has some sort of mandatory reviews and in case turn it off? thanks

@sseppi
Copy link
Contributor

sseppi commented Oct 30, 2023

@sseppi can you please verify if the repo has some sort of mandatory reviews and in case turn it off? thanks

@stefanodavid @mrabans I verified and removed the required approvals. As far as I know, in the lest period we didn't do any polica changes on this repo.

@sseppi sseppi merged commit 8282005 into master Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants