Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newest NeTEx feed, upgrade OTP #211

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

leonardehrenfried
Copy link
Contributor

This PR does the following:

  • it enables the new NeTEx feed that was provided by STA
  • upgrades to the latest version of OTP
  • it removes the Amarillo GTFS file from the build Amarillo is down

cc @rcavaliere

@clezag Do you know anything about Amadillo?

@leonardehrenfried
Copy link
Contributor Author

I'm not sure why the REUSE check fails. It complains about files that I haven not touched:

# MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* .gitmodules
* web-demo/.babelrc

The following files have no copyright information:
* web-demo/.eslintrc.js
* web-demo/.gitignore
* web-demo/README.md
* web-demo/craco-icons.js
* web-demo/craco.config.js
* web-demo/lib/app/app.js
* web-demo/lib/app/components/example.js
* web-demo/lib/app/config.js
* web-demo/lib/app/example.css
* web-demo/lib/app/index.css
* web-demo/lib/app/index.js
* web-demo/lib/app/index.tpl.html
* web-demo/lib/app/main.js
* web-demo/lib/config.yml
* web-demo/yarn.lock

@clezag Can you advise?

@clezag
Copy link
Member

clezag commented Nov 20, 2024

The REUSE issues are indeed not your fault, @ch-routerank has promised to file a PR to resolve this ; )
The check isn't blocking, so you can ignore it, as long as the files you touched are compliant.

Regarding Amarillo, there is an issue of cyclical dependency:

The Amarillo service you are referencing, is part of this very project deployment.
Which means, at build time, it's calling it's previous version.
If that happens to be down for some reason (and it is currently - I'll investigate why), subsequent deployments will fail every time.

The correct way would probably be for the build process to bootstrap it's own local amarillo+graphhopper instance and reference that in build-config.json. Or spin it off as a separate deployment

@leonardehrenfried
Copy link
Contributor Author

I would say that separating OTP builds from Amarillo ones would be a good solution. Seems weird that Amarillo somehow calls itself.

@leonardehrenfried
Copy link
Contributor Author

BTW, I have no permission to merge so you will have to do it once you're satisfied with this PR.

@clezag clezag merged commit c49041e into noi-techpark:main Nov 20, 2024
1 of 2 checks passed
@leonardehrenfried leonardehrenfried deleted the otp-upgrade branch November 20, 2024 13:18
@clezag
Copy link
Member

clezag commented Nov 20, 2024

I've fixed the (actually upstream) issue with Amarillo, and enabled it again.
Build ran through fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants