This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
chore!: replace black_box_function_supported with supports_opcode
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context on this, we'll also need to modify the These changes need to be made in ACVM so does't affect this PR directly. |
|
This needs to have it's base changed to the ACVM 0.12.0 branch. |
TomAFrench
reviewed
May 16, 2023
TomAFrench
changed the title
blackbox_supported with supports_opcode
TomAFrench
changed the title
blackbox_supported with supports_opcodeblack_box_function_supported with supports_opcode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the backend to indicate which opcode they support.
For instance we could have a TP backend which supports ROM opcode and not the RAM opcode.