Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix!: update pedersen hashes for new implementation #212

Merged
merged 1 commit into from
May 30, 2023
Merged

fix!: update pedersen hashes for new implementation #212

merged 1 commit into from
May 30, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented May 30, 2023 •
edited
Loading

Description

Problem*

Pedersen implementation changed in https://github.com/AztecProtocol/barretenberg/pull/414/files#diff-3efc25f3b79f11be68c59e48ae56e83dbd6f38a4c0505e2e3f5ddb3297b7c520

Summary*

Pointing barretenberg to this commit AztecProtocol/barretenberg@ad28215 and updated the pedersen tests

Example

Before:

After:

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant requested a review from kevaundray May 30, 2023 16:48
@sirasistant sirasistant changed the title fix: update pedersen hashes for new implemetation fix: update pedersen hashes for new implementation May 30, 2023
@kevaundray kevaundray enabled auto-merge May 30, 2023 17:12
@kevaundray kevaundray added this pull request to the merge queue May 30, 2023
@phated phated removed this pull request from the merge queue due to a manual request May 30, 2023
@phated
Copy link
Contributor

phated commented May 30, 2023

changing the bberg version is breaking.

@phated phated changed the title fix: update pedersen hashes for new implementation fix!: update pedersen hashes for new implementation May 30, 2023
@phated phated added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit 9a233ce May 30, 2023
@phated phated deleted the arv/new_pedersen branch May 30, 2023 18:03
@kobyhallx kobyhallx mentioned this pull request May 30, 2023
Merged
@Savio-Sou Savio-Sou mentioned this pull request May 31, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @phated @kevaundray