This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
chore!: allow backends to specify support for all opcode variants #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TomAFrench See the diff for adding Fn trait |
phated
reviewed
May 9, 2023
TomAFrench
force-pushed
the
kw/add-fn-trait-is-supported
branch
from
May 10, 2023 00:55
f0c7140
to
65090f2
Compare
phated
reviewed
May 10, 2023
TomAFrench
reviewed
May 11, 2023
TomAFrench
reviewed
May 12, 2023
TomAFrench
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge at this point. Some nits I don't feel too strongly about.
5 tasks
1 task
I touched this last so will let one of you two have the last word before merging. |
TomAFrench
changed the title
chore!: Backend specifies which Opcode is supported
chore!: allow backends to signal support for all opcode variants
May 16, 2023
TomAFrench
changed the title
chore!: allow backends to signal support for all opcode variants
chore!: allow backends to specify support for all opcode variants
May 16, 2023
6 tasks
sirasistant
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: chore!: allow backends to specify support for all opcode variants (#273)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #258
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)