Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore!: allow backends to specify support for all opcode variants #273

Merged
merged 13 commits into from
May 16, 2023

Conversation

kevaundray
Copy link
Contributor

Related to #258

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

Summary of changes

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@kevaundray
Copy link
Contributor Author

@TomAFrench See the diff for adding Fn trait

acvm/src/lib.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench force-pushed the kw/add-fn-trait-is-supported branch from f0c7140 to 65090f2 Compare May 10, 2023 00:55
acvm/src/compiler.rs Outdated Show resolved Hide resolved
acvm/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge at this point. Some nits I don't feel too strongly about.

acvm/src/compiler.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench requested a review from phated May 16, 2023 03:09
@TomAFrench
Copy link
Member

I touched this last so will let one of you two have the last word before merging.

@TomAFrench TomAFrench changed the title chore!: Backend specifies which Opcode is supported chore!: allow backends to signal support for all opcode variants May 16, 2023
@TomAFrench TomAFrench changed the title chore!: allow backends to signal support for all opcode variants chore!: allow backends to specify support for all opcode variants May 16, 2023
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench added this pull request to the merge queue May 16, 2023
Merged via the queue into master with commit efd37fe May 16, 2023
@github-actions github-actions bot mentioned this pull request May 16, 2023
TomAFrench added a commit that referenced this pull request May 17, 2023
* master:
  chore!: allow backends to specify support for all opcode variants (#273)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend::black_box_function_supported does not satisfy type IsOpcodeSupported
4 participants