This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(brillig): Support integers which fit inside a FieldElement
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
FieldElement
TomAFrench
changed the title
FieldElementFieldElement
|
Looks sensible to me. Any reason to not merge this at the moment? |
sirasistant
reviewed
Jul 20, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Brillig was limited to 128 bits for integer operations, which prevent to use brillig to replace the quotient directive (which itself replace the truncate directive which requires more than 128 bits)
Related to noir-lang/noir#1766
Summary*
We convert field elements to big integers and perform the operations on the big integers, using the provided bit size
Additional Context
PR Checklist*
cargo fmton default settings.