Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Jc/workspaces #342

Merged
merged 25 commits into from
Aug 28, 2023
Merged

Jc/workspaces #342

merged 25 commits into from
Aug 28, 2023

Conversation

critesjosh
Copy link
Collaborator

@critesjosh critesjosh commented Aug 18, 2023

closes #288
closes #324
closes #306
closes #316

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for noir-docs ready!

Name Link
🔨 Latest commit 2643c05
🔍 Latest deploy log https://app.netlify.com/sites/noir-docs/deploys/64ecde2f6d68910008cd102a
😎 Deploy Preview https://deploy-preview-342--noir-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@critesjosh critesjosh marked this pull request as ready for review August 22, 2023 00:34
Copy link
Collaborator

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick clarification, but other than that looks great!

docs/getting_started/02_breakdown.md Outdated Show resolved Hide resolved
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make some suggestions

docs/getting_started/02_breakdown.md Outdated Show resolved Hide resolved
docs/getting_started/02_breakdown.md Outdated Show resolved Hide resolved
docs/modules_packages_crates/crates_and_packages.md Outdated Show resolved Hide resolved
docs/modules_packages_crates/dependencies.md Outdated Show resolved Hide resolved
critesjosh and others added 16 commits August 25, 2023 10:32
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
…eakdown.md

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
…ies.md

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
…ies.md

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
critesjosh and others added 2 commits August 28, 2023 13:49
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@critesjosh critesjosh merged commit de67678 into master Aug 28, 2023
@critesjosh critesjosh deleted the jc/workspaces branch August 28, 2023 17:55
This was referenced Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Noir PR 2313 Document Noir PR 2267 Document Noir PR 2144 Document workspaces
3 participants