fix: Revert "correct result when assigning shared arrays" and added regression test #4584
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Report gates diff | |
| on: | |
| push: | |
| branches: | |
| - master | |
| pull_request: | |
| jobs: | |
| build-nargo: | |
| runs-on: ubuntu-latest | |
| strategy: | |
| matrix: | |
| target: [x86_64-unknown-linux-gnu] | |
| steps: | |
| - name: Checkout Noir repo | |
| uses: actions/checkout@v4 | |
| - name: Setup toolchain | |
| uses: dtolnay/rust-toolchain@1.71.1 | |
| - uses: Swatinem/rust-cache@v2 | |
| with: | |
| key: ${{ matrix.target }} | |
| cache-on-failure: true | |
| save-if: ${{ github.event_name != 'merge_group' }} | |
| - name: Build Nargo | |
| run: cargo build --package nargo_cli --release | |
| - name: Package artifacts | |
| run: | | |
| mkdir dist | |
| cp ./target/release/nargo ./dist/nargo | |
| 7z a -ttar -so -an ./dist/* | 7z a -si ./nargo-x86_64-unknown-linux-gnu.tar.gz | |
| - name: Upload artifact | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: nargo | |
| path: ./dist/* | |
| retention-days: 3 | |
| compare_gas_reports: | |
| needs: [build-nargo] | |
| runs-on: ubuntu-latest | |
| permissions: | |
| pull-requests: write | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Download nargo binary | |
| uses: actions/download-artifact@v4 | |
| with: | |
| name: nargo | |
| path: ./nargo | |
| - name: Set nargo on PATH | |
| run: | | |
| nargo_binary="${{ github.workspace }}/nargo/nargo" | |
| chmod +x $nargo_binary | |
| echo "$(dirname $nargo_binary)" >> $GITHUB_PATH | |
| export PATH="$PATH:$(dirname $nargo_binary)" | |
| nargo -V | |
| - name: Generate gates report | |
| working-directory: ./test_programs | |
| run: | | |
| ./gates_report.sh | |
| mv gates_report.json ../gates_report.json | |
| - name: Compare gates reports | |
| id: gates_diff | |
| uses: TomAFrench/noir-gates-diff@e7cf131b7e7f044c01615f93f0b855f65ddc02d4 | |
| with: | |
| report: gates_report.json | |
| summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) | |
| - name: Add gates diff to sticky comment | |
| if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' | |
| uses: marocchino/sticky-pull-request-comment@v2 | |
| with: | |
| # delete the comment in case changes no longer impact circuit sizes | |
| delete: ${{ !steps.gates_diff.outputs.markdown }} | |
| message: ${{ steps.gates_diff.outputs.markdown }} |