Revert "fix: correct result when assigning shared arrays in unconstra…

…ined code (#4210)"

This reverts commit bdd8a96.

compiler/noirc_evaluator/src/ssa/function_builder/mod.rs

@@ -384,9 +384,9 @@ impl FunctionBuilder {
                 }
             }
             Type::Array(..) | Type::Slice(..) => {
+                self.insert_instruction(Instruction::IncrementRc { value }, None);
                 // If there are nested arrays or slices, we wait until ArrayGet
                 // is issued to increment the count of that array.
-                self.insert_instruction(Instruction::IncrementRc { value }, None);
             }
         }
     }

compiler/noirc_evaluator/src/ssa/ssa_gen/context.rs

@@ -990,7 +990,6 @@ impl<'a> FunctionContext<'a> {
         new_value.for_each(|value| {
             let value = value.eval(self);
             array = self.builder.insert_array_set(array, index, value);
-            self.builder.increment_array_reference_count(array);
             index = self.builder.insert_binary(index, BinaryOp::Add, one);
         });
         array

compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs

@@ -724,11 +724,6 @@ impl<'a> FunctionContext<'a> {
         let lhs = self.extract_current_value(&assign.lvalue)?;
         let rhs = self.codegen_expression(&assign.expression)?;
 
-        rhs.clone().for_each(|value| {
-            let value = value.eval(self);
-            self.builder.increment_array_reference_count(value);
-        });
-
         self.assign_new_value(lhs, rhs);
         Ok(Self::unit_value())
     }