Skip to content

Commit

Permalink
patch bigint tests with new parameter to constant_or_witness_to_funct…
Browse files Browse the repository at this point in the history
…ion_inputs
  • Loading branch information
michaeljklein committed Aug 26, 2024
1 parent 0884b2f commit 4697680
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions acvm-repo/acvm/tests/solver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,6 @@ where
.collect()
}


prop_compose! {
fn bigint_with_modulus()(modulus in select(allowed_bigint_moduli()))
(inputs in proptest::collection::vec(any::<(u8, bool)>(), modulus.len()), modulus in Just(modulus))
Expand Down Expand Up @@ -935,8 +934,8 @@ fn bigint_solve_binary_op_opt(
.collect();
let initial_witness = WitnessMap::from(BTreeMap::from_iter(initial_witness_vec));

let lhs = constant_or_witness_to_function_inputs(lhs, 0);
let rhs = constant_or_witness_to_function_inputs(rhs, lhs.len());
let lhs = constant_or_witness_to_function_inputs(lhs, 0, None);
let rhs = constant_or_witness_to_function_inputs(rhs, lhs.len(), None);

let to_op_input = if middle_op.is_some() { 2 } else { 0 };

Expand Down Expand Up @@ -1182,7 +1181,7 @@ fn run_both_poseidon2_permutations(
external_poseidon2.permutation(&into_repr_vec(drop_use_constant(&inputs)));
(into_repr_vec(result), expected_result)
}

// Using the given BigInt modulus, solve the following circuit:
// - Convert xs, ys to BigInt's with ID's 0, 1, resp.
// - Run the middle_op:
Expand Down

0 comments on commit 4697680

Please sign in to comment.