Merge branch 'master' into HEAD

.aztec-sync-commit

@@ -0,0 +1 @@
+9e246c1289fa40c35c4b28d2f0081dfdc2aa9d19

.github/ACVM_NOT_PUBLISHABLE.md

@@ -0,0 +1,13 @@
+---
+title: "ACVM crates are not publishable"
+assignees: TomAFrench kevaundray savio-sou
+---
+
+
+The ACVM crates are currently unpublishable, making a release will NOT push our crates to crates.io.
+
+This is likely due to a crate we depend on bumping its MSRV above our own. Our lockfile is not taken into account when publishing to crates.io (as people downloading our crate don't use it) so we need to be able to use the most up to date versions of our dependencies (including transient dependencies) specified. 
+
+Check the [MSRV check]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`

.github/CRATES_IO_PUBLISH_FAILED.md

@@ -0,0 +1,10 @@
+---
+title: "ACVM crates failed to publish"
+assignees: TomAFrench kevaundray savio-sou
+---
+
+The {{env.CRATE_VERSION}} release of the ACVM crates failed.
+
+Check the [Publish ACVM]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -6,7 +6,7 @@ body:
     attributes:
       value: |
         # Description
-        Thanks for taking the time to create the Issue, and welcome to the Noirot family!
+        Thanks for taking the time to create the Issue and welcome to the Noir community!
   - type: textarea
     id: aim
     attributes:
@@ -38,45 +38,69 @@ body:
         2.
         3.
         4.
+  - type: dropdown
+    id: impact
+    attributes:
+      label: Project Impact
+      description: How does this affect a project you or others are working on? 
+      options:
+        - "Nice-to-have"
+        - "Blocker"
+  - type: textarea
+    id: impact_context
+    attributes:
+      label: Impact Context
+      description: If a nice-to-have / blocker, supplement how does this Issue affect the project.
+  - type: dropdown
+    id: workaround
+    attributes:
+      label: Workaround
+      description: Is there a workaround for this Issue? 
+      options:
+        - "Yes"
+  - type: textarea
+    id: workaround_description
+    attributes:
+      label: Workaround Description
+      description: If yes, supplement how could the Issue be worked around.
+  - type: textarea
+    id: additional
+    attributes:
+      label: Additional Context
+      description: Supplement further information if applicable.
   - type: markdown
     attributes:
       value: |
         # Environment
-        Specify your versions of Noir releases used.
+        Specify your version of Noir tooling used.
   - type: markdown
     attributes:
       value: |
-        ## Using Nargo?
+        ## Nargo (CLI)
   - type: dropdown
     id: nargo-install
     attributes:
       label: Installation Method
       description: How did you install Nargo?
-      multiple: false
       options:
-        - Binary
+        - Binary (`noirup` default)
         - Compiled from source
   - type: input
     id: nargo-version
     attributes:
       label: Nargo Version
-      description: What is the output of the `nargo --version` command?
-      placeholder: "nargo 0.6.0 (git version hash: 0181813203a9e3e46c6d8c3169ad5d25971d4282, is dirty: false)"
+      description: Output of running `nargo --version`
+      placeholder: "nargo version = 0.23.0 noirc version = 0.23.0+5be9f9d7e2f39ca228df10e5a530474af0331704 (git version hash: 5be9f9d7e2f39ca228df10e5a530474af0331704, is dirty: false)"
   - type: markdown
     attributes:
       value: |
-        ## Using TypeScript?
-        Please await for our new set of packages.
-        You can find our target release timeframe on the [Noir Roadmap](https://github.com/orgs/noir-lang/projects/1/views/16).
-  - type: markdown
-    attributes:
-      value: |
-        # Misc
-  - type: textarea
-    id: additional
+        ## NoirJS (JavaScript)
+  - type: input
+    id: noirjs-version
     attributes:
-      label: Additional Context
-      description: Supplement further information if applicable.
+      label: NoirJS Version
+      description: Version number of `noir_js` in `package.json`
+      placeholder: "0.23.0"
   - type: markdown
     attributes:
       value: |
@@ -87,11 +111,8 @@ body:
       label: Would you like to submit a PR for this Issue?
       description: Fellow contributors are happy to provide support where applicable.
       options:
-        - "No"
         - "Maybe"
         - "Yes"
-    validations:
-      required: true
   - type: textarea
     id: pr_support
     attributes:

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -6,7 +6,7 @@ body:
     attributes:
       value: |
         ## Description
-        Thanks for taking the time to create the Issue, and welcome to the Noirot family!
+        Thanks for taking the time to create the Issue and welcome to the Noir community!
   - type: textarea
     id: problem
     attributes:
@@ -21,11 +21,31 @@ body:
       description: Describe how you think it should work. Supply pseudocode / step-by-step examples if applicable.
     validations:
       required: true
+  - type: dropdown
+    id: impact
+    attributes:
+      label: Project Impact
+      description: How does this affect a project you or others are working on? 
+      options:
+        - "Nice-to-have"
+        - "Blocker"
   - type: textarea
-    id: alternatives
+    id: impact_context
     attributes:
-      label: Alternatives Considered
-      description: Describe less-happy cases you have considered, if any.
+      label: Impact Context
+      description: If a nice-to-have / blocker, supplement how does this Issue affect the project.
+  - type: dropdown
+    id: workaround
+    attributes:
+      label: Workaround
+      description: Is there a workaround for this Issue? 
+      options:
+        - "Yes"
+  - type: textarea
+    id: workaround_description
+    attributes:
+      label: Workaround Description
+      description: If yes, supplement how could the Issue be worked around.
   - type: textarea
     id: additional
     attributes:
@@ -42,11 +62,8 @@ body:
       description: Fellow contributors are happy to provide support where applicable.
       multiple: false
       options:
-        - "No"
         - "Maybe"
         - "Yes"
-    validations:
-      required: true
   - type: textarea
     id: pr-support
     attributes:

.github/JS_PUBLISH_FAILED.md

@@ -0,0 +1,11 @@
+---
+title: "JS packages failed to publish"
+assignees: TomAFrench kevaundray savio-sou
+labels: js
+---
+
+The {{env.NPM_TAG}} release of the JS packages failed.
+
+Check the [Publish JS packages]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`

.github/actions/install-playwright/action.yml

@@ -9,7 +9,7 @@ runs:
       run: echo "PLAYWRIGHT_VERSION=$(yarn workspace @noir-lang/noirc_abi info @web/test-runner-playwright --json | jq .children.Version | tr -d '"')" >> $GITHUB_ENV
 
     - name: Cache playwright binaries
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       id: playwright-cache
       with:
         path: |
@@ -19,6 +19,5 @@ runs:
     - name: Install playwright deps
       shell: bash
       if: steps.playwright-cache.outputs.cache-hit != 'true'
-      run: |
-        npx playwright install
-        npx playwright install-deps
+      run: ./.github/scripts/playwright-install.sh
+

.github/actions/setup/action.yml

@@ -7,7 +7,7 @@ runs:
     - uses: actions/setup-node@v4
       id: node
       with:
-        node-version: 18.17.1
+        node-version: 18.19.0
         cache: 'yarn'
         cache-dependency-path: 'yarn.lock'
 

.github/scripts/acvm_js-test-browser.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
 set -eu
 
-npx playwright install && npx playwright install-deps
+./.github/scripts/playwright-install.sh
 yarn workspace @noir-lang/acvm_js test:browser

.github/scripts/cargo-binstall-install.sh

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+set -eu
+
+curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash

.github/scripts/integration-test-browser.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+set -eu
+
+./.github/scripts/playwright-install.sh
+yarn workspace integration-tests test:browser

.github/scripts/integration-test-node.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+set -eu
+
+apt-get install libc++-dev -y
+yarn workspace integration-tests test:node

.github/scripts/noir-js-test.sh

@@ -1,6 +1,4 @@
 #!/bin/bash
 set -eu
 
-./scripts/nargo_compile_noir_js_assert_lt.sh
-rm -rf /usr/src/noir/tooling/noir_js/test/noir_compiled_examples/assert_lt/target/debug_assert_lt.json
-yarn workspace @noir-lang/noir_js test
+yarn workspace @noir-lang/noir_js test

.github/scripts/noir-wasm-test-browser.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 set -eu
 
-./scripts/nargo_compile_wasm_fixtures.sh
-npx playwright install && npx playwright install-deps
-yarn workspace @noir-lang/noir_wasm test:browser
+./.github/scripts/playwright-install.sh
+yarn workspace @noir-lang/noir_wasm test:build_fixtures
+yarn workspace @noir-lang/noir_wasm test:browser

.github/scripts/noir-wasm-test.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 set -eu
 
-./scripts/nargo_compile_wasm_fixtures.sh
+yarn workspace @noir-lang/noir_wasm test:build_fixtures
 yarn workspace @noir-lang/noir_wasm test:node
-npx playwright install && npx playwright install-deps
+./.github/scripts/playwright-install.sh
 yarn workspace @noir-lang/noir_wasm test:browser

.github/scripts/noirc-abi-test-browser.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
 set -eu
 
-npx playwright install && npx playwright install-deps
+./.github/scripts/playwright-install.sh
 yarn workspace @noir-lang/noirc_abi test:browser

.github/scripts/integration-test.sh → .github/scripts/playwright-install.sh

@@ -1,6 +1,4 @@
 #!/bin/bash
 set -eu
 
-apt-get install libc++-dev -y
 npx playwright install && npx playwright install-deps
-yarn workspace integration-tests test

.github/scripts/wasm-bindgen-install.sh

@@ -1,5 +1,13 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -eu
 
-# TODO call this script directly
-./scripts/install_wasm-bindgen.sh
+cd $(dirname "$0")
+
+./cargo-binstall-install.sh
+
+# Install wasm-bindgen-cli.
+if [ "$(wasm-bindgen --version | cut -d' ' -f2)" != "0.2.86" ]; then
+  echo "Building wasm-bindgen..."
+  cargo binstall wasm-bindgen-cli@0.2.86 --force --no-confirm
+fi
+

.github/scripts/wasm-opt-install.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+set -eu
+
+cd $(dirname "$0")
+
+./cargo-binstall-install.sh
+
+cargo-binstall wasm-opt --version 0.116.0 -y

.github/scripts/wasm-pack-install.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 set -eu
 
-curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
+cd $(dirname "$0")
+
+./cargo-binstall-install.sh
+
 cargo-binstall wasm-pack --version 0.12.1 -y