Skip to content

Commit

Permalink
chore: remove malformed functions from brillig reports (#6898)
Browse files Browse the repository at this point in the history
  • Loading branch information
TomAFrench authored Dec 20, 2024
1 parent 186fbb7 commit 913be5b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
- name: Compare gates reports
id: gates_diff
uses: noir-lang/noir-gates-diff@1931aaaa848a1a009363d6115293f7b7fc72bb87
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report.json
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
- name: Compare Brillig bytecode size reports
id: brillig_bytecode_diff
uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report_brillig.json
header: |
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
- name: Compare Brillig execution reports
id: brillig_execution_diff
uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report_brillig_execution.json
header: |
Expand Down
2 changes: 1 addition & 1 deletion test_programs/gates_report.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ for pathname in $test_dirs; do
fi

GATES_INFO=$($BACKEND gates -b "$artifacts_path/$ARTIFACT_NAME/target/program.json")
MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}]}")
MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}], unconstrained_functions: []}")
echo -n $MAIN_FUNCTION_INFO >> gates_report.json

if (($ITER == $NUM_ARTIFACTS)); then
Expand Down
2 changes: 1 addition & 1 deletion test_programs/gates_report_brillig.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ done

echo "]" >> Nargo.toml

nargo info --force-brillig --json > gates_report_brillig.json
nargo info --force-brillig --json | jq -r ".programs[].functions = []" > gates_report_brillig.json

rm Nargo.toml
4 changes: 2 additions & 2 deletions test_programs/gates_report_brillig_execution.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ done

echo "]" >> Nargo.toml

nargo info --profile-execution --json > gates_report_brillig_execution.json
nargo info --profile-execution --json | jq -r ".programs[].functions = []" > gates_report_brillig_execution.json

rm Nargo.toml
rm Nargo.toml

0 comments on commit 913be5b

Please sign in to comment.