feat: test_programs that are invisible to git now pass, add skipping …

…for compile_success_empty, add skipping for compile_failure (skips generating test), add error for this case, catch that error instead of throwing it with a non-zero exit code, add is_package_visible_to_git, add test program w/ .gitignore exception to test this, add expected failure to prevent regressions, add 'target' dir case

.gitignore

@@ -30,6 +30,7 @@ tooling/noir_js/lib
 **/target
 !test_programs/acir_artifacts/*/target
 !test_programs/acir_artifacts/*/target/witness.gz
+!test_programs/compile_success_empty/workspace_usually_gitignored/bin/Verifier.toml
 !compiler/wasm/noir-script/target
 
 gates_report.json

test_programs/compile_success_empty/workspace_usually_gitignored/bin/Verifier.toml

@@ -0,0 +1 @@
+return = ""

tooling/nargo_cli/Cargo.toml

@@ -17,6 +17,7 @@ path = "src/main.rs"
 
 [build-dependencies]
 build-data.workspace = true
+nargo_toml.workspace = true
 toml.workspace = true
 
 [dependencies]

tooling/nargo_cli/build.rs

@@ -3,6 +3,8 @@ use std::io::Write;
 use std::path::{Path, PathBuf};
 use std::{env, fs};
 
+use nargo_toml::{find_package_root, ManifestError};
+
 const GIT_COMMIT: &&str = &"GIT_COMMIT";
 
 fn main() {
@@ -230,6 +232,11 @@ fn compile_success_empty_{test_name}() {{
         panic!("`nargo info` failed with: {{}}", String::from_utf8(output.stderr).unwrap_or_default());
     }}
 
+    // skip empty test packages
+    if std::str::from_utf8(&output.stdout).unwrap_or("").contains("cannot find any files visible to git at the following path") {{
+        return ()
+    }}
+
     // `compile_success_empty` tests should be able to compile down to an empty circuit.
     let json: serde_json::Value = serde_json::from_slice(&output.stdout).unwrap_or_else(|e| {{
         panic!("JSON was not well-formatted {{:?}}\n\n{{:?}}", e, std::str::from_utf8(&output.stdout))
@@ -299,6 +306,16 @@ fn generate_compile_failure_tests(test_file: &mut File, test_data_dir: &Path) {
         };
         let test_dir = &test_dir.path();
 
+        match find_package_root(test_dir) {
+            Ok(_) => (),
+            Err(err) => {
+                // avoid testing when there are no files in the test_dir
+                return if matches!(err, ManifestError::InvisibleToGit(..)) {
+                    continue;
+                };
+            }
+        }
+
         write!(
             test_file,
             r#"

tooling/nargo_cli/src/cli/mod.rs

@@ -1,6 +1,6 @@
 use clap::{Args, Parser, Subcommand};
 use const_format::formatcp;
-use nargo_toml::find_package_root;
+use nargo_toml::{find_package_root, ManifestError};
 use noirc_driver::NOIR_ARTIFACT_VERSION_STRING;
 use std::path::PathBuf;
 
@@ -100,7 +100,18 @@ pub(crate) fn start_cli() -> eyre::Result<()> {
             | NargoCommand::Backend(_)
             | NargoCommand::Dap(_)
     ) {
-        config.program_dir = find_package_root(&config.program_dir)?;
+        match find_package_root(&config.program_dir) {
+            Ok(program_dir) => config.program_dir = program_dir,
+            Err(err) => {
+                // avoid erroring when there are no files in the program_dir
+                return if matches!(err, ManifestError::InvisibleToGit(..)) {
+                    println!("{}", err);
+                    Ok(())
+                } else {
+                    Err(err.into())
+                };
+            }
+        }
     }
 
     let active_backend = get_active_backend();

tooling/nargo_toml/src/errors.rs

@@ -12,6 +12,10 @@ pub enum ManifestError {
     #[error("cannot find a Nargo.toml for {0}")]
     MissingFile(PathBuf),
 
+    /// Package doesn't contain any files that are visible to git
+    #[error("cannot find any files visible to git at the following path (skipping): {0}")]
+    InvisibleToGit(PathBuf),
+
     #[error("Cannot read file {0} - does it exist?")]
     ReadFailed(PathBuf),
 

tooling/nargo_toml/src/lib.rs

@@ -5,6 +5,7 @@
 
 use std::{
     collections::BTreeMap,
+    ffi::OsStr,
     path::{Component, Path, PathBuf},
 };
 
@@ -92,14 +93,47 @@ pub fn find_package_manifest(
         }
 
         // Return the shallowest Nargo.toml, which will be the last in the list
-        found_toml_paths.pop().ok_or_else(|| ManifestError::MissingFile(current_path.to_path_buf()))
+        found_toml_paths.pop().ok_or_else(|| {
+            if is_package_visible_to_git(current_path) {
+                ManifestError::MissingFile(current_path.to_path_buf())
+            } else {
+                ManifestError::InvisibleToGit(current_path.to_path_buf())
+            }
+        })
     } else {
         Err(ManifestError::NoCommonAncestor {
             root: root_path.to_path_buf(),
             current: current_path.to_path_buf(),
         })
     }
 }
+
+/// Check whether the given path is visible to git.
+/// A package can become invisible to git when its visible contents are deleted,
+/// but its folders remain, as can happen from git merges.
+fn is_package_visible_to_git(current_path: &Path) -> bool {
+    if current_path.is_file() {
+        // **/Verifier.toml
+        if current_path.file_name() != Some(OsStr::new("Verifier.toml")) {
+            return true;
+        }
+    } else {
+        // **/target
+        // !test_programs/acir_artifacts/*/target
+        if current_path.file_name() == Some(OsStr::new("target")) {
+            return current_path.to_str().unwrap_or("").contains("acir_artifacts");
+        }
+
+        for sub_path_entry in current_path.read_dir().expect("path to exist during compilation") {
+            let sub_path = sub_path_entry.expect("path to exist during compilation").path();
+            if is_package_visible_to_git(&sub_path) {
+                return true;
+            }
+        }
+    }
+    false
+}
+
 /// Returns the [PathBuf] of the `Nargo.toml` file in the `current_path` directory.
 ///
 /// Returns a [ManifestError] if `current_path` does not contain a manifest file.