Merge branch 'master' into kh-rename-functions

* master: (416 commits)
  chore: replace cached `in_contract` with `in_contract()` method (#5324)
  fix: fix usage of `#[abi(tag)]` attribute with elaborator (#5298)
  fix: don't benchmark the "prove" command as it doesn't exist anymore (#5323)
  feat(stdlib): Update stdlib to use explicit numeric generics (#5306)
  feat: let `should_fail_with` check that the failure reason contains the expected message (#5319)
  chore: bump `bb` to 0.43.0 (#5321)
  feat(frontend): Explicit numeric generics and type kinds (#5155)
  feat(frontend): Where clause on impl (#5320)
  chore: add back Pedersen blackbox functions (revert PR 5221) (#5318)
  fix: skip emission of brillig calls which will never be executed (#5314)
  feat: Make macros operate on token streams instead of AST nodes (#5301)
  chore: Bundle SSA Evaluator Options (#5317)
  fix: Replace panic in monomorphization with an error (#5305)
  fix(nargo_fmt): Account for spaces before the generic list of a function (#5303)
  fix: update `in_contract` flag before handling function metadata in elaborator (#5292)
  fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (#5278)
  chore: refactor test case generation in build.rs (#5280)
  fix: handle struct with nested arrays in oracle return values (#5244)
  feat: build simple dictionary from inspecting ACIR program (#5264)
  fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (#5009)
  ...

.aztec-sync-commit

@@ -0,0 +1 @@
+12af650f0d27c37dca06bb329bf76a5574534d78

.github/ACVM_NOT_PUBLISHABLE.md

@@ -0,0 +1,12 @@
+---
+title: "ACVM crates are not publishable"
+assignees: TomAFrench, Savio-Sou
+---
+
+The ACVM crates are currently unpublishable, making a release will NOT push our crates to crates.io.
+
+This is likely due to a crate we depend on bumping its MSRV above our own. Our lockfile is not taken into account when publishing to crates.io (as people downloading our crate don't use it) so we need to be able to use the most up to date versions of our dependencies (including transient dependencies) specified. 
+
+Check the [MSRV check]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`

.github/ACVM_PUBLISH_FAILED.md

@@ -0,0 +1,10 @@
+---
+title: "ACVM crates failed to publish"
+assignees: TomAFrench, Savio-Sou
+---
+
+The {{env.CRATE_VERSION}} release of the ACVM crates failed.
+
+Check the [Publish ACVM crates]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`

.github/CRATES_IO_PUBLISH_FAILED.md

@@ -1,6 +1,6 @@
 ---
 title: "ACVM crates failed to publish"
-assignees: TomAFrench kevaundray savio-sou
+assignees: TomAFrench, Savio-Sou
 ---
 
 The {{env.CRATE_VERSION}} release of the ACVM crates failed.

.github/Cross.toml

@@ -2,7 +2,6 @@
 passthrough = [
     "HOME",
     "RUST_BACKTRACE",
-    "BARRETENBERG_BIN_DIR"
 ]
 volumes = [
     "HOME",

.github/DEAD_LINKS_IN_DOCS.md

@@ -1,6 +1,6 @@
 ---
 title: "Docs contains dead links"
-assignees: signorecello catmcgee critesjosh jzaki Savio-Sou
+assignees: signorecello, catmcgee, critesjosh, jzaki, Savio-Sou
 labels: documentation
 ---
 

.github/JS_PUBLISH_FAILED.md

@@ -1,6 +1,6 @@
 ---
 title: "JS packages failed to publish"
-assignees: TomAFrench kevaundray savio-sou
+assignees: TomAFrench, Savio-Sou
 labels: js
 ---
 

.github/actions/install-playwright/action.yml

@@ -4,20 +4,23 @@ description: Installs Playwright and its dependencies and caches them.
 runs:
   using: composite
   steps:
-    - name: Query playwright version
-      shell: bash
-      run: echo "PLAYWRIGHT_VERSION=$(yarn workspace @noir-lang/noirc_abi info @web/test-runner-playwright --json | jq .children.Version | tr -d '"')" >> $GITHUB_ENV
+    # - name: Query playwright version
+    #   shell: bash
+    #   run: echo "PLAYWRIGHT_VERSION=$(yarn workspace @noir-lang/noirc_abi info @web/test-runner-playwright --json | jq .children.Version | tr -d '"')" >> $GITHUB_ENV
 
-    - name: Cache playwright binaries
-      uses: actions/cache@v4
-      id: playwright-cache
-      with:
-        path: |
-          ~/.cache/ms-playwright
-        key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}
+    # - name: Cache playwright binaries
+    #   uses: actions/cache@v4
+    #   id: playwright-cache
+    #   with:
+    #     path: |
+    #       ~/.cache/ms-playwright
+    #     key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}
 
     - name: Install playwright deps
       shell: bash
-      if: steps.playwright-cache.outputs.cache-hit != 'true'
-      run: ./.github/scripts/playwright-install.sh
+      # if: steps.playwright-cache.outputs.cache-hit != 'true'
+      run: |
+        # Workaround: https://github.com/microsoft/playwright/issues/30503#issuecomment-2074783821
+        sudo rm /etc/apt/sources.list.d/microsoft-prod.list
+        ./.github/scripts/playwright-install.sh
 

.github/pull_request_template.md

@@ -17,7 +17,7 @@ Resolves <!-- Link to GitHub Issue -->
 Check one:
 - [ ] No documentation needed.
 - [ ] Documentation included in this PR.
-- [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR.
+- [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR.
 
 # PR Checklist\*
 

.github/scripts/acvm_js-build.sh

@@ -2,4 +2,5 @@
 set -eu
 
 .github/scripts/wasm-bindgen-install.sh
+.github/scripts/wasm-opt-install.sh
 yarn workspace @noir-lang/acvm_js build

.github/scripts/noir-wasm-build.sh

@@ -2,4 +2,6 @@
 set -eu
 
 .github/scripts/wasm-pack-install.sh
+.github/scripts/wasm-opt-install.sh
+yarn workspace @noir-lang/types build
 yarn workspace @noir-lang/noir_wasm build

.github/scripts/noirc-abi-build.sh

@@ -2,4 +2,5 @@
 set -eu
 
 .github/scripts/wasm-bindgen-install.sh
+.github/scripts/wasm-opt-install.sh
 yarn workspace @noir-lang/noirc_abi build

.github/scripts/wasm-bindgen-install.sh

@@ -6,7 +6,7 @@ cd $(dirname "$0")
 ./cargo-binstall-install.sh
 
 # Install wasm-bindgen-cli.
-if [ "$(wasm-bindgen --version | cut -d' ' -f2)" != "0.2.86" ]; then
+if [ "$(wasm-bindgen --version &> /dev/null | cut -d' ' -f2)" != "0.2.86" ]; then
   echo "Building wasm-bindgen..."
   cargo binstall wasm-bindgen-cli@0.2.86 --force --no-confirm
 fi

.github/scripts/wasm-opt-install.sh

@@ -5,4 +5,4 @@ cd $(dirname "$0")
 
 ./cargo-binstall-install.sh
 
-cargo-binstall wasm-opt --version 0.116.0 -y
+cargo-binstall wasm-opt --version 0.116.0 -y --force