Skip to content

Commit

Permalink
chore: add a workflow that tracks acvm version for integration tests (#…
Browse files Browse the repository at this point in the history
…2700)

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
  • Loading branch information
4 people authored Sep 16, 2023
1 parent 4aa6b49 commit a8af95b
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 16 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/track-acvm.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Track ACVM for Integration Tests

on:
pull_request:
paths:
- 'Cargo.lock'
- 'yarn.lock'

jobs:
check_matching_version:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Check acvm version change
run: |
# Extract acvm version from the current Cargo.lock
CURRENT_VERSION=$(awk '/name = "acvm"/ {getline; print $3}' Cargo.lock | tr -d '"')
INTEGRATION_TEST_VERSION=$(yarn workspace integration-tests info @noir-lang/acvm_js --json | jq .children.Version | tr -d '"')
echo "Current ACVM Version: $CURRENT_VERSION"
echo "Integration Test ACVM Version: $INTEGRATION_TEST_VERSION"
if [ "$CURRENT_VERSION" != "$INTEGRATION_TEST_VERSION" ]; then
exit 1
else
echo "ACVM version is a match."
fi
4 changes: 2 additions & 2 deletions compiler/integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0"
},
"dependencies": {
"@aztec/bb.js": "^0.5.1",
"@noir-lang/acvm_js": "^0.26.0",
"@aztec/bb.js": "^0.6.7",
"@noir-lang/acvm_js": "^0.26.1",
"@noir-lang/noir_wasm": "workspace:*",
"@noir-lang/noirc_abi": "workspace:*",
"@noir-lang/source-resolver": "workspace:*",
Expand Down
21 changes: 7 additions & 14 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ __metadata:
languageName: node
linkType: hard

"@aztec/bb.js@npm:^0.5.1":
version: 0.5.1
resolution: "@aztec/bb.js@npm:0.5.1"
"@aztec/bb.js@npm:^0.6.7":
version: 0.6.7
resolution: "@aztec/bb.js@npm:0.6.7"
dependencies:
comlink: ^4.4.1
commander: ^10.0.1
debug: ^4.3.4
tslib: ^2.4.0
bin:
bb.js: dest/node/main.js
checksum: 0a191106e6c6eb842181bf856779b2b461136e07a60068b9ae15e9f2e42f993fe4122c343f5946bc16654ef560b227850e8cba3a10c7c3a0a3940d606647f694
checksum: 9067e9c4c5e51de173261bb5feebe6c4f6fc2be0381e2b30301fd5ed6794c5a20f5242427b7701384bc6285cd65e04e2fa914010923d1671cf59c8674b6545eb
languageName: node
linkType: hard

Expand Down Expand Up @@ -385,20 +385,13 @@ __metadata:
languageName: node
linkType: hard

"@noir-lang/acvm_js@npm:0.26.1":
"@noir-lang/acvm_js@npm:0.26.1, @noir-lang/acvm_js@npm:^0.26.1":
version: 0.26.1
resolution: "@noir-lang/acvm_js@npm:0.26.1"
checksum: ae8cb6e31610cd8aa392855342d0c953a1bc4cd9e07236340341afa5815696a69a6635c38241f1d6a5dd30c5a8ae49234f2ba8b71d46c5d1a46756ff6f4dde3a
languageName: node
linkType: hard

"@noir-lang/acvm_js@npm:^0.26.0":
version: 0.26.0
resolution: "@noir-lang/acvm_js@npm:0.26.0"
checksum: 3325b611fec4531363cb67682d50ea40cbeaf8da7672c8373cb11bc7786308a14c61804950b4805e071edc9298005039847621a8d79fae185eda2cf981c64b39
languageName: node
linkType: hard

"@noir-lang/noir_js@workspace:tooling/noir_js":
version: 0.0.0-use.local
resolution: "@noir-lang/noir_js@workspace:tooling/noir_js"
Expand Down Expand Up @@ -4288,8 +4281,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "integration-tests@workspace:compiler/integration-tests"
dependencies:
"@aztec/bb.js": ^0.5.1
"@noir-lang/acvm_js": ^0.26.0
"@aztec/bb.js": ^0.6.7
"@noir-lang/acvm_js": ^0.26.1
"@noir-lang/noir_wasm": "workspace:*"
"@noir-lang/noirc_abi": "workspace:*"
"@noir-lang/source-resolver": "workspace:*"
Expand Down

0 comments on commit a8af95b

Please sign in to comment.