Skip to content

Commit

Permalink
Merge branch 'mv/brillig-opcode-report' into mv/test-brillig-opcode-r…
Browse files Browse the repository at this point in the history
…eport
  • Loading branch information
TomAFrench authored Aug 19, 2024
2 parents 6b70236 + 63b3d02 commit b2be50e
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions .github/workflows/gates_report_brillig.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Report Brillig opcodes diff
name: Report Brillig bytecode size diff

on:
push:
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
path: ./dist/*
retention-days: 3

compare_brillig_opcode_reports:
compare_brillig_bytecode_size_reports:
needs: [build-nargo]
runs-on: ubuntu-latest
permissions:
Expand All @@ -65,24 +65,26 @@ jobs:
export PATH="$PATH:$(dirname $nargo_binary)"
nargo -V
- name: Generate Brillig opcodes report
- name: Generate Brillig bytecode size report
working-directory: ./test_programs
run: |
chmod +x gates_report_brillig.sh
./gates_report_brillig.sh
mv gates_report_brillig.json ../gates_report_brillig.json
- name: Compare Brillig opcode reports
id: gates_diff
uses: noir-lang/noir-gates-diff@93e4cae1229d669de61f0ac76d32e47cefe4adcc
- name: Compare Brillig bytecode size reports
id: brillig_bytecode_diff
uses: noir-lang/noir-gates-diff@cd8721ebe0ad9a67889c601063cccc33a8ca7f32
with:
report: gates_report_brillig.json
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
header: |
# Changes to Brillig bytecode sizes
summaryQuantile: 0.9 # only display the 10% most significant bytecode size diffs in the summary (defaults to 20%)

- name: Add gates diff to sticky comment
- name: Add bytecode size diff to sticky comment
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
uses: marocchino/sticky-pull-request-comment@v2
with:
# delete the comment in case changes no longer impact circuit sizes
delete: ${{ !steps.gates_diff.outputs.markdown }}
message: ${{ steps.gates_diff.outputs.markdown }}
# delete the comment in case changes no longer impact brillig bytecode sizes
delete: ${{ !steps.brillig_bytecode_diff.outputs.markdown }}
message: ${{ steps.brillig_bytecode_diff.outputs.markdown }}

0 comments on commit b2be50e

Please sign in to comment.