Skip to content

Commit

Permalink
chore: address TODO in compat.nr (#5339)
Browse files Browse the repository at this point in the history
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*

This PR addresses a TODO in the stdlib now that #5245 is resolved.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Jun 26, 2024
1 parent c7dcda4 commit b66414f
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions noir_stdlib/src/compat.nr
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
global BN254_MODULUS_BE_BYTES: [u8; 32] = [
global BN254_MODULUS_BE_BYTES: [u8] = &[
48, 100, 78, 114, 225, 49, 160, 41, 184, 80, 69, 182, 129, 129, 88, 93, 40, 51, 232, 72, 121, 185, 112, 145, 67, 225, 245, 147, 240, 0, 0, 1
];

pub fn is_bn254() -> bool {
// TODO: refactor this once https://github.com/noir-lang/noir/issues/5245 is resolved.
let modulus_bytes = crate::field::modulus_be_bytes();
if modulus_bytes.len() == 32 {
let mut modulus_bytes_array: [u8; 32] = [0; 32];
for i in 0..32 {
modulus_bytes_array[i] = modulus_bytes[i];
}

modulus_bytes_array == BN254_MODULUS_BE_BYTES
} else {
false
}
crate::field::modulus_be_bytes() == BN254_MODULUS_BE_BYTES
}

0 comments on commit b66414f

Please sign in to comment.