Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test noir_wasm on PR #1229

Closed
1 task
Tracked by #2163
jonybur opened this issue Apr 26, 2023 · 3 comments · Fixed by #1921
Closed
1 task
Tracked by #2163

Test noir_wasm on PR #1229

jonybur opened this issue Apr 26, 2023 · 3 comments · Fixed by #1921
Assignees
@jonybur
Labels
enhancement New feature or request

Comments

@jonybur
Copy link
Contributor

jonybur commented Apr 26, 2023

Problem

Avoid breaking changes in noir_wasm when updating noir.

Proposed solution

Use noir-wasm-testing on PR

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@jonybur jonybur added the enhancement New feature or request label Apr 26, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 26, 2023
@jonybur jonybur mentioned this issue Apr 26, 2023
Merged
6 tasks
@kobyhallx
Copy link
Contributor

Building and testing of noir_wasm need to happen in noir-lang/noir flake.nix where wasm output needs to get defined and "check wasm" output is used for testing.

@jonybur
Copy link
Contributor Author

jonybur commented May 9, 2023 •
edited
Loading

Currently working on that, on this PR -

(work in progress)

@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir May 16, 2023
@jonybur jonybur moved this from 🏗 In progress to 🚧 Blocked in Noir Jun 5, 2023
@Savio-Sou Savio-Sou moved this from 🚧 Blocked to 🏗 In progress in Noir Jun 10, 2023
@jonybur
Copy link
Contributor Author

jonybur commented Jun 13, 2023

Moved to this PR: #1660

@jonybur jonybur removed this from Noir Jul 14, 2023
@jonybur jonybur mentioned this issue Jul 24, 2023
Merged
5 tasks
@Savio-Sou Savio-Sou added this to Noir Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 27, 2023
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Jul 27, 2023
@Savio-Sou Savio-Sou mentioned this issue Aug 4, 2023
Closed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Aug 7, 2023
@Savio-Sou Savio-Sou mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonybur jonybur

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add noir_wasm testing workflow noir-lang/noir
3 participants
@jonybur @kevaundray @kobyhallx