Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: E2E headless browser tests #2163

Closed
7 tasks done
Tracked by #2711
Savio-Sou opened this issue Aug 4, 2023 · 1 comment
Closed
7 tasks done
Tracked by #2711

Epic: E2E headless browser tests #2163

Savio-Sou opened this issue Aug 4, 2023 · 1 comment
Assignees
Milestone

Comments

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Aug 4, 2023

Prerequisites

Preview Give feedback
  1. E-MEDIUM P-MEDIUM enhancement
    jonybur
  2. 2 of 2
    jonybur
  3. 5 of 6
    kevaundray
  4. kobyhallx
  5. bug
    kobyhallx phated
  6. enhancement
    jonybur kobyhallx

The test suite should cover:

In CLI:

  1. Compiling Noir programs into ACIRs with Nargo / noir_wasm (should be equivalent, up to engineering's recommendation)
  2. Generate Solidity verifiers for the Noir programs with bb.js
  3. Deploy the Solidity verifiers

In headless browser:

  1. Generates witnesses with acvm_js
  2. Prove the ACIRs + witnesses with bb.js
  3. Submit proofs to the Solidity verifiers

For discussion

  1. What tests to include?

    Could be based on tooling/nargo_cli/tests

  2. Should we include downloading from npm in the test suite?

@Savio-Sou Savio-Sou added this to Noir Jul 27, 2023
@Savio-Sou Savio-Sou converted this from a draft issue Aug 4, 2023
@kevaundray
Copy link
Contributor

@kobyhallx who is owning this EPIC?

@kobyhallx kobyhallx self-assigned this Sep 8, 2023
@Savio-Sou Savio-Sou moved this to 🏗 In progress in Noir Sep 11, 2023
@Savio-Sou Savio-Sou added this to the Beta milestone Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants