Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssa refactor): mem2reg opt pass #1363

Merged
merged 5 commits into from
May 18, 2023
Merged

feat(ssa refactor): mem2reg opt pass #1363

merged 5 commits into from
May 18, 2023

Conversation

joss-aztec
Copy link
Contributor

Related issue(s)

Resolves #1353

Description

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@joss-aztec joss-aztec marked this pull request as ready for review May 17, 2023 17:39
@joss-aztec
Copy link
Contributor Author

fyi, I removed the .rev() from BasicBlock::remove_instruction as it was removing the element at the mirrored position.

jfecher
jfecher approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My thinking is lets get this version of the pass now and we can add to it later as separate PRs.

@jfecher jfecher added this pull request to the merge queue May 18, 2023
Merged via the queue into master with commit 5d1efd5 May 18, 2023
@jfecher jfecher deleted the joss/mem2reg branch May 18, 2023 18:56
@kevaundray kevaundray mentioned this pull request May 18, 2023
Closed
TomAFrench added a commit that referenced this pull request May 23, 2023
@TomAFrench
Merge branch 'phated/acvm-0.12.0' into mv/opcode_supported
4aba46e 
* phated/acvm-0.12.0:
  fix compilation issue
  switch to published acvm and backend
  feat(nargo): Consume CommonReferenceString functions & manage caching (#1348)
  fix(stdlib): Workaround for Field comparison error in EdDSA signature verification (#1372)
  feat!: remove concept of noir fallbacks for foreign functions (#1371)
  feat(ssa refactor): mem2reg opt pass (#1363)
  feat(stdlib): EdDSA sig verification (#1313)
@kevaundray kevaundray mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block scoped store/load -> folding simplifcation
2 participants
@joss-aztec @jfecher