Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generational arenas #15

Closed
kevaundray opened this issue Mar 16, 2021 · 3 comments · Fixed by #4207
Closed

Remove generational arenas #15

kevaundray opened this issue Mar 16, 2021 · 3 comments · Fixed by #4207
Assignees
@michaeljklein
Labels
compiler good first issue Good for newcomers

Comments

@kevaundray
Copy link
Contributor

For the use-case it is possible to opt for a simpler arena implementation like la-arena. Which also allows you to tag your data structure.
@kevaundray
Copy link
Contributor Author

@f01dab1e please give this a try when you are free!

@kevaundray
Copy link
Contributor Author

la-arena is here: https://docs.rs/la-arena/latest/la_arena/ fyi

@kevaundray kevaundray added the good first issue Good for newcomers label Jan 15, 2024
@kevaundray kevaundray added this to the 0.24 milestone Jan 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 25, 2024
@jfecher
Copy link
Contributor

jfecher commented Jan 29, 2024

We never free these items so we can just use Vec

@michaeljklein michaeljklein mentioned this issue Jan 30, 2024
Merged
5 tasks
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Feb 2, 2024
@Savio-Sou Savio-Sou removed this from the 0.24 milestone Feb 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
@michaeljklein @kevaundray @jfecher
chore: remove dependency on generational-arena (#4207)
46f2204 
# Description

## Problem\*

Resolves
#15 (comment)

## Summary\*

Replaces `generational-arena`'s `Arena` class with a thin wrapper around
`Vec`

## Additional Context

The thin wrapper is helpful for:
1. `insert` returning the index
2. `iter` iterating over the `(index, item)` pairs

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Jake Fecher <jfecher11@gmail.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
compiler good first issue Good for newcomers
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove dependency on generational-arena noir-lang/noir
4 participants
@michaeljklein @jfecher @kevaundray @Savio-Sou